Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental metric reader and view cardinality limits #5494

Merged

Conversation

jack-berg
Copy link
Member

Resolves #5489.

@jack-berg jack-berg requested a review from a team May 31, 2023 19:26
@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Patch coverage: 88.88% and project coverage change: -0.05 ⚠️

Comparison is base (83f9144) 91.33% compared to head (fe16b7b) 91.28%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5494      +/-   ##
============================================
- Coverage     91.33%   91.28%   -0.05%     
- Complexity     4891     4896       +5     
============================================
  Files           547      548       +1     
  Lines         14410    14446      +36     
  Branches       1354     1354              
============================================
+ Hits          13161    13187      +26     
- Misses          865      873       +8     
- Partials        384      386       +2     
Impacted Files Coverage Δ
...etry/sdk/metrics/internal/state/MetricStorage.java 0.00% <ø> (ø)
...java/io/opentelemetry/sdk/metrics/ViewBuilder.java 90.47% <66.66%> (-9.53%) ⬇️
...try/sdk/metrics/internal/SdkMeterProviderUtil.java 76.19% <73.33%> (-1.59%) ⬇️
...io/opentelemetry/sdk/metrics/SdkMeterProvider.java 95.52% <100.00%> (+0.13%) ⬆️
...telemetry/sdk/metrics/SdkMeterProviderBuilder.java 100.00% <100.00%> (ø)
...c/main/java/io/opentelemetry/sdk/metrics/View.java 100.00% <100.00%> (ø)
...rics/internal/export/CardinalityLimitSelector.java 100.00% <100.00%> (ø)
...rics/internal/state/AsynchronousMetricStorage.java 98.38% <100.00%> (+0.05%) ⬆️
...nternal/state/DefaultSynchronousMetricStorage.java 93.10% <100.00%> (+0.12%) ⬆️
...trics/internal/state/SynchronousMetricStorage.java 75.00% <100.00%> (+2.27%) ⬆️
... and 2 more

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jack-berg jack-berg added this to the v1.27.0 milestone Jun 8, 2023
@jack-berg jack-berg merged commit 331c6af into open-telemetry:main Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add configurable cardinality limits to metrics
3 participants