-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stabilize RetryPolicy API for OTLP exporters #5524
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #5524 +/- ##
============================================
- Coverage 91.33% 91.32% -0.01%
+ Complexity 4969 4954 -15
============================================
Files 552 551 -1
Lines 14591 14588 -3
Branches 1357 1357
============================================
- Hits 13326 13323 -3
Misses 876 876
Partials 389 389
☔ View full report in Codecov by Sentry. |
mateuszrzeszutek
approved these changes
Jun 12, 2023
sdk/common/src/main/java/io/opentelemetry/sdk/common/export/RetryPolicyBuilder.java
Outdated
Show resolved
Hide resolved
exporters/common/src/test/java/io/opentelemetry/exporter/internal/retry/RetryPolicyTest.java
Outdated
Show resolved
Hide resolved
bogdandrutu
reviewed
Jun 13, 2023
sdk/common/src/main/java/io/opentelemetry/sdk/common/export/RetryPolicyBuilder.java
Outdated
Show resolved
Hide resolved
…y-java into stabilize-retry-api
mateuszrzeszutek
approved these changes
Jun 16, 2023
jkwatson
approved these changes
Jul 5, 2023
…y-java into stabilize-retry-api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discussed the stability status of OTLP exporter retry in the 5/25 java SIG. I mentioned that while I still don't think we can enable retry by default in autoconfigure until this spec issue is resolved, I do think we should stabilize the API configuration of retry.
This means moving RetryPolicy, RetryPolicyBuilder to stable package / artifact, and adding
setRetryPolicy(RetryPolicy)
methods to the OTLP exporter builder classes. That's what this PR accomplishs.There's an interesting question about where RetryPolicy should live. It currently lives in an internal package in
opentelemetry-exporters-common
, which has no public API surface area. Rather than adding new public API surface area and being stuck with that artfiact / package, I thought a better home would beopentelemetry-sdk-common
.