Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental JdkHttpSender #5557

Merged
merged 9 commits into from
Jul 6, 2023

Conversation

jack-berg
Copy link
Member

Resolves #5351.

@jack-berg jack-berg requested a review from a team June 20, 2023 21:04
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Patch coverage: 88.95% and project coverage change: -0.03 ⚠️

Comparison is base (7bd06ef) 91.32% compared to head (ad28caf) 91.29%.

❗ Current head ad28caf differs from pull request most recent head 06ff288. Consider uploading reports for the commit 06ff288 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5557      +/-   ##
============================================
- Coverage     91.32%   91.29%   -0.03%     
- Complexity     4953     4996      +43     
============================================
  Files           551      555       +4     
  Lines         14588    14752     +164     
  Branches       1357     1376      +19     
============================================
+ Hits          13322    13468     +146     
- Misses          876      888      +12     
- Partials        390      396       +6     
Impacted Files Coverage Δ
...orter/sender/okhttp/internal/OkHttpHttpSender.java 98.43% <ø> (ø)
...ry/exporter/sender/jdk/internal/JdkHttpSender.java 87.36% <87.36%> (ø)
...ry/exporter/sender/jdk/internal/BodyPublisher.java 88.46% <88.46%> (ø)
...ry/exporter/internal/http/HttpExporterBuilder.java 93.65% <95.45%> (+1.49%) ⬆️
...ter/sender/jdk/internal/JdkHttpSenderProvider.java 100.00% <100.00%> (ø)
...nder/okhttp/internal/OkHttpHttpSenderProvider.java 100.00% <100.00%> (ø)

... and 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@jkwatson jkwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@io7m
Copy link

io7m commented Jul 9, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should we provide jdk11 version of OTLP http exporters?
4 participants