Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After cardinality limit exceeded record measurements to overflow series #5560

Merged
merged 3 commits into from
Jul 6, 2023

Conversation

jack-berg
Copy link
Member

Resolves #5490.

@jack-berg jack-berg requested a review from a team June 21, 2023 19:21
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Patch coverage: 78.26% and project coverage change: -0.03 ⚠️

Comparison is base (fec52b4) 91.39% compared to head (1e42540) 91.37%.

❗ Current head 1e42540 differs from pull request most recent head c5ea6af. Consider uploading reports for the commit c5ea6af to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5560      +/-   ##
============================================
- Coverage     91.39%   91.37%   -0.03%     
  Complexity     4963     4963              
============================================
  Files           550      550              
  Lines         14569    14579      +10     
  Branches       1358     1357       -1     
============================================
+ Hits          13316    13322       +6     
- Misses          866      870       +4     
  Partials        387      387              
Impacted Files Coverage Δ
...rics/internal/state/AsynchronousMetricStorage.java 91.42% <64.28%> (-6.96%) ⬇️
...nternal/state/DefaultSynchronousMetricStorage.java 93.22% <100.00%> (+0.11%) ⬆️
...etry/sdk/metrics/internal/state/MetricStorage.java 50.00% <100.00%> (+50.00%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aggregate overflow measurements into overflow series
3 participants