Change OpenCensus shim default sampling to defer to OpenTelemetry #5604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabmass
changed the title
jsuereth
approved these changes
Jul 7, 2023
|
Not at all opposed to this change, but do we have specification language about this behavior at the moment? |
|
It's not mentioned in the spec https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/compatibility/opencensus.md |
|
@jsuereth is this worth putting into the spec for the OC shim? |
|
@jkwatson Yes, I think we can call it out in the specification, however I don't think that's necessary to merge this patch. Specifically, I think the behavior in Java actually deviates from the other shims. |
|
How can I move this forward? |
|
I don't think either of our maintainers have much of any expertise in OC, so I'm going to merge this and let @jsuereth manage any fallout. ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the default OpenCensus sampler would run before the shim calls the OpenTelemetry API. This causes both the OpenCensus and OpenTelemetry samplers to be evaluated, and they must both pass to be sampled.
This PR changes the default OpenCensus sampler for the shim to be
Samplers.alwaysSample(). That way, users can just configure Sampling in OpenTelemetry.