Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gradle java version requirement warning #5624

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

jack-berg
Copy link
Member

The existing warning is wrong (says java 11 is required to build instead of java 17) and is in the wrong place (gradle fails with compatibility exception when building buildSrc before the build.gradle.kts has a chance to run).

@jack-berg jack-berg requested a review from a team July 12, 2023 02:53
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b0c5c04) 91.32% compared to head (8f7da88) 91.32%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5624   +/-   ##
=========================================
  Coverage     91.32%   91.32%           
  Complexity     4979     4979           
=========================================
  Files           554      554           
  Lines         14731    14731           
  Branches       1376     1376           
=========================================
  Hits          13453    13453           
  Misses          884      884           
  Partials        394      394           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants