Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental autoconfigure support for customizing cardinality limit #5659

Merged
merged 4 commits into from
Aug 9, 2023

Conversation

jack-berg
Copy link
Member

Resolves #5639.

@jack-berg jack-berg requested a review from a team July 27, 2023 21:16
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (e980e8b) 91.31% compared to head (801ea26) 91.31%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5659   +/-   ##
=========================================
  Coverage     91.31%   91.31%           
- Complexity     5001     5004    +3     
=========================================
  Files           554      554           
  Lines         14811    14817    +6     
  Branches       1382     1383    +1     
=========================================
+ Hits          13524    13530    +6     
  Misses          889      889           
  Partials        398      398           
Files Changed Coverage Δ
.../sdk/autoconfigure/MeterProviderConfiguration.java 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jack-berg jack-berg merged commit f27280a into open-telemetry:main Aug 9, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add cardinality configuration option to sdk autoconfigure
4 participants