Refactor SpiUtil to improve mocking #5679
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on file configuration stuff, which will have to load SPI implementations like autoconfigure. We currently have most of our SPI related code in static methods in
SpiUtil
, which makes testing / mocking difficult.This refactors the SPI accessors in an
SpiHelper
class.SpiHeler
accepts aClassLoader
as an argument, and can be passed around autoconfigure (and soon file configuration interpretation code) in place ofClassLoader
. It contains accessors for the various ways we load SPI implementations (named and configurable viaConfigProperties
, orders, and a plain list).Much better for mocking in tests.
This is a strict refactor.