Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from snakeyaml to snakeyaml engine #5691

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

trask
Copy link
Member

@trask trask commented Aug 7, 2023

We switched from snakeyaml to snakeyaml-engine in #5138.

One of the motivations for this was because of https://nvd.nist.gov/vuln/detail/CVE-2022-1471.

Since then, snakeyaml agreed to release 2.0 to address/quiet scanners: https://bitbucket.org/snakeyaml/snakeyaml/issues/561/cve-2022-1471-vulnerability-in#comment-64876314 (which is great).

Still probably a good idea to consolidate on snakeyaml-engine.

Btw, this doesn't remove snakeyaml from the classpath, since jackson-dataformat-yaml still uses snakeyaml. They have updated to snakeyaml-engine in master, but won't be released until 3.0 (https://github.com/FasterXML/jackson-dataformats-text/tree/master/yaml).

@trask trask requested a review from a team August 7, 2023 23:43
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d4a3b3b) 91.34% compared to head (d088120) 91.34%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5691   +/-   ##
=========================================
  Coverage     91.34%   91.34%           
  Complexity     4997     4997           
=========================================
  Files           554      554           
  Lines         14793    14793           
  Branches       1379     1379           
=========================================
  Hits          13513    13513           
  Misses          883      883           
  Partials        397      397           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops thanks!

@jack-berg jack-berg merged commit 88c80b1 into open-telemetry:main Aug 8, 2023
16 checks passed
@trask trask deleted the use-snakeyaml-engine branch August 8, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants