Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase metric name maximum length from 63 to 255 characters #5697

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

trask
Copy link
Member

@trask trask commented Aug 9, 2023

Pending spec PR open-telemetry/opentelemetry-specification#3648 Spec update is merged!

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02% ⚠️

Comparison is base (076115e) 91.28% compared to head (f5523f2) 91.26%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5697      +/-   ##
============================================
- Coverage     91.28%   91.26%   -0.02%     
- Complexity     5016     5032      +16     
============================================
  Files           554      556       +2     
  Lines         14860    14861       +1     
  Branches       1387     1389       +2     
============================================
- Hits          13565    13563       -2     
- Misses          893      896       +3     
  Partials        402      402              
Files Changed Coverage Δ
.../main/java/io/opentelemetry/api/metrics/Meter.java 0.00% <ø> (ø)
...in/java/io/opentelemetry/sdk/metrics/SdkMeter.java 98.03% <100.00%> (ø)

... and 26 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trask trask marked this pull request as ready for review August 10, 2023 17:59
@trask trask requested a review from a team August 10, 2023 17:59
@jack-berg
Copy link
Member

Should hold off on this for 1.29.0 release since this didn't make it into the 1.24.0 spec release.

@trask
Copy link
Member Author

trask commented Aug 10, 2023

Should hold off on this for 1.29.0 release since this didn't make it into the 1.24.0 spec release.

makes sense based on open-telemetry/opentelemetry-specification#2728 (comment)

@trask
Copy link
Member Author

trask commented Aug 30, 2023

I'm really hoping this makes it into 1.30.0 🤞🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants