prometheus exporter: add units to metric names in TYPE and HELP comments #5718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
force-pushed
the
unit_in_names
branch
9 times, most recently
from
723dadb
to
a1ba5ec
Compare
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
mateuszrzeszutek
approved these changes
Aug 17, 2023
...rometheus/src/main/java/io/opentelemetry/exporter/prometheus/PrometheusMetricNameMapper.java
Outdated
Show resolved
Hide resolved
exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Serializer.java
Outdated
Show resolved
Hide resolved
dashpole
force-pushed
the
unit_in_names
branch
3 times, most recently
from
805c189
to
44da63b
Compare
jack-berg
reviewed
Aug 30, 2023
...rometheus/src/main/java/io/opentelemetry/exporter/prometheus/PrometheusMetricNameMapper.java
Outdated
Show resolved
Hide resolved
jack-berg
approved these changes
Aug 30, 2023
dashpole
force-pushed
the
unit_in_names
branch
from
44da63b
to
83780c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5716
Changes:
_totalsuffix is always added after unit suffixes by trimming it before adding unit suffixes.