-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement attributes advice for the rest of the instruments #5722
Implement attributes advice for the rest of the instruments #5722
Conversation
equalTo(stringKey("key2"), "2"), equalTo(stringKey("key3"), "3")))); | ||
} | ||
|
||
static final class InstrumentsProvider implements ArgumentsProvider { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The argument provider turned out to be a monster, but at least the test cases are very terse and easy to read
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #5722 +/- ##
============================================
+ Coverage 91.27% 91.30% +0.02%
- Complexity 5051 5106 +55
============================================
Files 558 570 +12
Lines 14930 15162 +232
Branches 1397 1421 +24
============================================
+ Hits 13627 13843 +216
- Misses 897 910 +13
- Partials 406 409 +3
☔ View full report in Codecov by Sentry. |
This is great, thanks @mateuszrzeszutek! |
Continuation of #5677