Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement attributes advice for the rest of the instruments #5722

Conversation

mateuszrzeszutek
Copy link
Member

Continuation of #5677

@mateuszrzeszutek mateuszrzeszutek requested a review from a team August 17, 2023 09:02
equalTo(stringKey("key2"), "2"), equalTo(stringKey("key3"), "3"))));
}

static final class InstrumentsProvider implements ArgumentsProvider {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The argument provider turned out to be a monster, but at least the test cases are very terse and easy to read

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch coverage: 82.75% and project coverage change: +0.02% 🎉

Comparison is base (0e63447) 91.27% compared to head (9c2c850) 91.30%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5722      +/-   ##
============================================
+ Coverage     91.27%   91.30%   +0.02%     
- Complexity     5051     5106      +55     
============================================
  Files           558      570      +12     
  Lines         14930    15162     +232     
  Branches       1397     1421      +24     
============================================
+ Hits          13627    13843     +216     
- Misses          897      910      +13     
- Partials        406      409       +3     
Files Changed Coverage Δ
...ncubator/metrics/ExtendedDoubleCounterBuilder.java 0.00% <ø> (ø)
.../incubator/metrics/ExtendedDoubleGaugeBuilder.java 0.00% <0.00%> (ø)
...or/metrics/ExtendedDoubleUpDownCounterBuilder.java 0.00% <0.00%> (ø)
.../incubator/metrics/ExtendedLongCounterBuilder.java 0.00% <0.00%> (ø)
...on/incubator/metrics/ExtendedLongGaugeBuilder.java 0.00% <0.00%> (ø)
...ator/metrics/ExtendedLongUpDownCounterBuilder.java 0.00% <0.00%> (ø)
...io/opentelemetry/sdk/metrics/SdkDoubleCounter.java 100.00% <ø> (ø)
...entelemetry/sdk/metrics/SdkDoubleGaugeBuilder.java 100.00% <100.00%> (ø)
.../opentelemetry/sdk/metrics/SdkDoubleHistogram.java 100.00% <100.00%> (ø)
...ntelemetry/sdk/metrics/SdkDoubleUpDownCounter.java 100.00% <100.00%> (ø)
... and 4 more

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jack-berg
Copy link
Member

This is great, thanks @mateuszrzeszutek!

@jack-berg jack-berg merged commit 4b06f09 into open-telemetry:main Aug 23, 2023
17 checks passed
@mateuszrzeszutek mateuszrzeszutek deleted the implement-attributes-advice-for-other-instruments branch August 23, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants