Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SpanExporterFactory support for zipkin exporter #5771

Merged
merged 2 commits into from
Aug 28, 2023

Conversation

jack-berg
Copy link
Member

Builds on #5751, #5687, #5399, #5757, #5758, #5763 by adding logic to interpret the sampler portion of configuration schema.

@jack-berg jack-berg requested a review from a team August 25, 2023 17:53
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Patch coverage: 92.85% and project coverage change: -0.02% ⚠️

Comparison is base (01503ef) 91.34% compared to head (c9aca7c) 91.32%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5771      +/-   ##
============================================
- Coverage     91.34%   91.32%   -0.02%     
- Complexity     5335     5341       +6     
============================================
  Files           592      592              
  Lines         15811    15831      +20     
  Branches       1564     1567       +3     
============================================
+ Hits          14442    14458      +16     
- Misses          937      939       +2     
- Partials        432      434       +2     
Files Changed Coverage Δ
...try/exporter/zipkin/ZipkinSpanExporterBuilder.java 94.11% <80.00%> (-3.61%) ⬇️
...ntelemetry/exporter/zipkin/ZipkinSpanExporter.java 93.47% <100.00%> (+0.29%) ⬆️
...sion/incubator/fileconfig/SpanExporterFactory.java 92.30% <100.00%> (-2.82%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jack-berg jack-berg merged commit ce7323e into open-telemetry:main Aug 28, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants