Add clearer docs around coroutine support with an example #5799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scprek
commented
Sep 8, 2023
extensions/kotlin/README.md
Outdated
| @@ -0,0 +1,13 @@ | |||
| # OpenTelemetry Kotlin Extension | |||
|
|
|||
| To enable kotlin support, you need to add the `io.opentelemetry:opentelemetry-extension-kotlin` dependency. | |||
There was a problem hiding this comment.
maybe goes unsaid, but as for the info/example below I personally had to dig into stackoverflow comments/responses to find and also came up in micronaut community forum on how to do.
There was a problem hiding this comment.
This is documented in the README. I have a mild preference for having each piece of info live in one place to reduce the chance of it going out of date.
trask
approved these changes
Sep 13, 2023
scprek
force-pushed
the
kotlin-ext-readme
branch
from
76ea36f
to
9a3bbc6
Compare
scprek
force-pushed
the
kotlin-ext-readme
branch
from
9a3bbc6
to
4fc09ed
Compare
Codecov ReportAll modified lines are covered by tests ✅ 📢 Thoughts on this report? Let us know!. |
jack-berg
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved from open-telemetry/opentelemetry-java-instrumentation#8833