Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dismantle AbstractInstrumentBuilder inheritance hierarchy #5820

Merged
merged 11 commits into from
Oct 13, 2023
Merged

Dismantle AbstractInstrumentBuilder inheritance hierarchy #5820

merged 11 commits into from
Oct 13, 2023

Commits on Oct 10, 2023

  1. make AbstractInstrumentBuilder final, rename, and use delegation

    @breedx-splk
    breedx-splk committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    bc852f8 View commit details
    Browse the repository at this point in the history

  2. remove constructor overload

    @breedx-splk
    breedx-splk committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    19b6dff View commit details
    Browse the repository at this point in the history

  3. spotless

    @breedx-splk
    breedx-splk committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    23ce7a7 View commit details
    Browse the repository at this point in the history

  4. make build naming consistent

    @breedx-splk
    breedx-splk committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    43f0ecd View commit details
    Browse the repository at this point in the history

  5. encapsulate stateful fields inside a mutable descriptor

    @breedx-splk
    breedx-splk committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    a372bf5 View commit details
    Browse the repository at this point in the history

  6. address review comments

    @breedx-splk
    breedx-splk committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    a1563a6 View commit details
    Browse the repository at this point in the history

  7. fixups after rebase

    @breedx-splk
    breedx-splk committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    8947708 View commit details
    Browse the repository at this point in the history

  8. fixups after rebase

    @breedx-splk
    breedx-splk committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    02e2e99 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2023

  1. roll MutableInstrumentDescriptor into InstrumentBuilder

    @breedx-splk
    breedx-splk committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    35634cb View commit details
    Browse the repository at this point in the history

  2. remove public

    @breedx-splk
    breedx-splk committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    15463e8 View commit details
    Browse the repository at this point in the history

  3. require type and valueType in InstrumentBuilder construction

    @breedx-splk
    breedx-splk committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    28563ea View commit details
    Browse the repository at this point in the history