Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify queueSize metric description and attribute #5836

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Unify queueSize metric description and attribute #5836

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b137847
set queueSize metric description and attribute
puckpuck Sep 16, 2023
b1f53a5
set queueSize metric description and attribute
puckpuck Sep 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

## Unreleased

* Update `queueSize` metric description and attribute name for `processorType`
([#5836](https://github.com/open-telemetry/opentelemetry-java/pull/5836))

## Version 1.30.1 (2023-09-11)

* Fix autoconfigure bug creating multiple `PrometheusHttpServer` instances with same port
Expand Down
4 changes: 2 additions & 2 deletions sdk/logs/src/main/java/io/opentelemetry/sdk/logs/export/BatchLogRecordProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public final class BatchLogRecordProcessor implements LogRecordProcessor {
private static final String WORKER_THREAD_NAME =
BatchLogRecordProcessor.class.getSimpleName() + "_WorkerThread";
private static final AttributeKey<String> LOG_RECORD_PROCESSOR_TYPE_LABEL =
AttributeKey.stringKey("logRecordProcessorType");
AttributeKey.stringKey("processorType");
private static final AttributeKey<Boolean> LOG_RECORD_PROCESSOR_DROPPED_LABEL =
AttributeKey.booleanKey("dropped");
private static final String LOG_RECORD_PROCESSOR_TYPE_VALUE =
Expand Down Expand Up @@ -172,7 +172,7 @@ private Worker(
meter
.gaugeBuilder("queueSize")
.ofLongs()
.setDescription("The number of logs queued")
.setDescription("The number of items queued")
.setUnit("1")
.buildWithCallback(
result ->
Expand Down
4 changes: 2 additions & 2 deletions sdk/trace/src/main/java/io/opentelemetry/sdk/trace/export/BatchSpanProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ public final class BatchSpanProcessor implements SpanProcessor {
private static final String WORKER_THREAD_NAME =
BatchSpanProcessor.class.getSimpleName() + "_WorkerThread";
private static final AttributeKey<String> SPAN_PROCESSOR_TYPE_LABEL =
AttributeKey.stringKey("spanProcessorType");
AttributeKey.stringKey("processorType");
private static final AttributeKey<Boolean> SPAN_PROCESSOR_DROPPED_LABEL =
AttributeKey.booleanKey("dropped");
private static final String SPAN_PROCESSOR_TYPE_VALUE = BatchSpanProcessor.class.getSimpleName();
Expand Down Expand Up @@ -189,7 +189,7 @@ private Worker(
meter
.gaugeBuilder("queueSize")
.ofLongs()
.setDescription("The number of spans queued")
.setDescription("The number of items queued")
.setUnit("1")
.buildWithCallback(
result ->
Expand Down