Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move results to benchmark folder #5875

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Move results to benchmark folder #5875

merged 1 commit into from
Oct 6, 2023

Conversation

tylerbenson
Copy link
Member

@tylerbenson tylerbenson commented Oct 2, 2023 •
edited
Loading

For consistency with other repos.

Depends on #5874

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 2, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: tylerbenson / name: Tyler Benson (72901e3)

@tylerbenson tylerbenson mentioned this pull request Oct 2, 2023
Merged
trask
trask reviewed Oct 2, 2023
View reviewed changes
Copy link
Member

@trask trask left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you think the redirect is needed?

EDIT in general my thought would be to not include it, so people don't get used to it

@tylerbenson
Copy link
Member Author

(I dropped the extra commit where I added the redirect.)

@tylerbenson
Copy link
Member Author

@jack-berg once this is merged, I'll rebase the other PR to get the latest data moved over.

@jack-berg
Copy link
Member

Will merge once the conflict is resolved

@tylerbenson
Move results to benchmark folder
72901e3 
For consistency with other repos.
@tylerbenson
Copy link
Member Author

Done. Please merge this before merging anything else otherwise another rebase will be required.

@jack-berg jack-berg merged commit 9abfbd2 into open-telemetry:benchmarks Oct 6, 2023
1 check passed
@tylerbenson tylerbenson deleted the benchmarks branch October 6, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask left review comments

@jack-berg jack-berg jack-berg approved these changes

@breedx-splk breedx-splk breedx-splk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tylerbenson @jack-berg @trask @breedx-splk