Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a tag to identify OkHttp calls made from OTel exporters #5906

Conversation

LikeTheSalad
Copy link
Contributor

Related to #5886

After deciding to use an internal solution in the previous SIG, and also raising concerns about the usage of a Context key due to performance penalties, I believe this approach is the most straightforward and stable way to identify OTel's OkHttp calls for internal, automatic instrumentation purposes, since it doesn't need to use Context keys, nor does it need to rely on Thread's values propagation or intercepting threads that OkHttp will use for async calls (in case of using ThreadLocals) or relying on the thread's name, since it seems like it's being changed before running OkHttp's interceptors, which is where the automatic traces are created.

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
...orter/sender/okhttp/internal/OkHttpGrpcSender.java 78.88% <100.00%> (ø)
...orter/sender/okhttp/internal/OkHttpHttpSender.java 98.43% <100.00%> (ø)
...ry/exporter/sender/okhttp/internal/OkHttpUtil.java 100.00% <100.00%> (ø)
.../fileconfig/OpenTelemetryConfigurationFactory.java 100.00% <100.00%> (ø)
...ension/incubator/fileconfig/PropagatorFactory.java 100.00% <100.00%> (ø)
...incubator/fileconfig/TextMapPropagatorFactory.java 100.00% <100.00%> (ø)

📢 Thoughts on this report? Let us know!.

@LikeTheSalad LikeTheSalad marked this pull request as ready for review October 11, 2023 18:02
@LikeTheSalad LikeTheSalad requested a review from a team October 11, 2023 18:02
@LikeTheSalad
Copy link
Contributor Author

Replaced by: #5918

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant