Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow events to be emitted with timestamp #5928

Merged
merged 9 commits into from
Nov 9, 2023

Conversation

breedx-splk
Copy link
Contributor

There are several cases where events may need to be emitted with a timestamp that is different from "now" (the current time), the main ones being:

  • Handling events that occur prior to SDK initialization
  • Event log recording/playback

These are not contrived use cases. In Android, we have a specific need to track certain startup behaviors, and the sdk creation is not necessarily early enough in the application lifecycle to handle this.

@breedx-splk breedx-splk requested a review from a team October 18, 2023 22:30
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
.../opentelemetry/api/events/DefaultEventEmitter.java 100.00% <100.00%> (ø)
...entelemetry/sdk/logs/internal/SdkEventBuilder.java 100.00% <100.00%> (ø)
...try/sdk/logs/internal/SdkEventEmitterProvider.java 83.72% <100.00%> (+2.14%) ⬆️

... and 49 files with indirect coverage changes

📢 Thoughts on this report? Let us know!

@jack-berg jack-berg added this to the 1.32.0 milestone Nov 3, 2023
@jack-berg jack-berg merged commit 83993e0 into open-telemetry:main Nov 9, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants