Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize log body any value #5938

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

jack-berg
Copy link
Member

Followup to #5880 which updates OTLP log record marshaling to properly encode AnyValue log bodies.

Leaving as a draft until #5880 is resolved.

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Files Coverage Δ
...etry/exporter/internal/marshal/JsonSerializer.java 94.28% <ø> (+2.85%) ⬆️
...try/exporter/internal/marshal/ProtoSerializer.java 96.47% <ø> (ø)
...elemetry/exporter/internal/marshal/Serializer.java 79.78% <ø> (ø)
...exporter/internal/otlp/ArrayAnyValueMarshaler.java 100.00% <100.00%> (ø)
.../exporter/internal/otlp/BoolAnyValueMarshaler.java 100.00% <100.00%> (ø)
...exporter/internal/otlp/BytesAnyValueMarshaler.java 100.00% <100.00%> (ø)
...xporter/internal/otlp/DoubleAnyValueMarshaler.java 100.00% <100.00%> (ø)
...r/internal/otlp/InstrumentationScopeMarshaler.java 94.44% <100.00%> (+0.15%) ⬆️
...y/exporter/internal/otlp/IntAnyValueMarshaler.java 100.00% <100.00%> (ø)
...r/internal/otlp/KeyValueListAnyValueMarshaler.java 100.00% <100.00%> (ø)
... and 14 more

📢 Thoughts on this report? Let us know!.

@jack-berg jack-berg marked this pull request as ready for review November 3, 2023 19:40
@jack-berg jack-berg requested a review from a team November 3, 2023 19:40
@jack-berg
Copy link
Member Author

Marking this PR as ready for review since #5880 has been merged.

@jack-berg jack-berg added this to the 1.32.0 milestone Nov 3, 2023
@jack-berg jack-berg modified the milestones: 1.32.0, 1.33.0 Nov 13, 2023
@scheler
Copy link

scheler commented Dec 4, 2023

@open-telemetry/java-approvers can you please take a look and review this PR? We want to use these changes and hence interested in getting this PR merged. Thanks.

@jack-berg jack-berg merged commit 9a3391d into open-telemetry:main Dec 7, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants