Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log support to junit extensions #5966

Merged

Conversation

jack-berg
Copy link
Member

Just extending the JUnit extensions with missing log support. Came across this omission writing some custom instrumentation the other day.

@jack-berg jack-berg requested a review from a team November 7, 2023 19:21
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
...elemetry/sdk/testing/junit4/OpenTelemetryRule.java 100.00% <100.00%> (ø)
...try/sdk/testing/junit5/OpenTelemetryExtension.java 100.00% <100.00%> (ø)

... and 17 files with indirect coverage changes

📢 Thoughts on this report? Let us know!

@jack-berg jack-berg merged commit b03ec3a into open-telemetry:main Nov 9, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants