Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compressor SPI to support additional compression algos #5990

Merged
merged 3 commits into from
Jan 2, 2024

Conversation

jack-berg
Copy link
Member

@jack-berg jack-berg commented Nov 16, 2023

Related to #5196.

I would say this closes the issue, but we might also consider adding a contrib artifact containing one or more popular alternatives to gzip.

If folks agree on the direction, I'll followup on this to extend support to the gRPC version of the OTLP exporters.

@jack-berg jack-berg requested a review from a team November 16, 2023 00:27
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (0c436e0) 91.12% compared to head (97f7861) 91.13%.
Report is 1 commits behind head on main.

Files Patch % Lines
.../exporter/internal/compression/CompressorUtil.java 84.61% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5990   +/-   ##
=========================================
  Coverage     91.12%   91.13%           
- Complexity     5736     5742    +6     
=========================================
  Files           628      630    +2     
  Lines         16810    16844   +34     
  Branches       1662     1664    +2     
=========================================
+ Hits          15318    15350   +32     
- Misses         1028     1029    +1     
- Partials        464      465    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jack-berg
Copy link
Member Author

Draft PR to add a zstd implementation to contrib: open-telemetry/opentelemetry-java-contrib#1108

@jack-berg jack-berg added this to the 1.33.0 milestone Nov 30, 2023
@jkwatson
Copy link
Contributor

I think this seems like a great approach. One very small comment: it might be better not to pull in another test dependency, but just create a fake compressor (maybe one that just base64s or something if you want it to change the payload) for testing. Only better in that it's one less dependency that has to be maintained/upgraded/etc.

@jack-berg jack-berg removed this from the 1.33.0 milestone Jan 2, 2024
@jack-berg
Copy link
Member Author

Nice suggestion. I pushed a commit to use base64 to test the mechanism and removed the lz4 dependency.

Copy link
Contributor

@jkwatson jkwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@jack-berg jack-berg merged commit 60ae0af into open-telemetry:main Jan 2, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants