Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert histogram measurements to double before passing recording exemplar reservoir #6024

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

jack-berg
Copy link
Member

Resolves #6010.

@jack-berg jack-berg requested a review from a team November 28, 2023 21:36
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c57ca65) 91.16% compared to head (ff5595a) 91.20%.
Report is 3 commits behind head on main.

❗ Current head ff5595a differs from pull request most recent head c40a4cb. Consider uploading reports for the commit c40a4cb to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6024      +/-   ##
============================================
+ Coverage     91.16%   91.20%   +0.04%     
- Complexity     5613     5621       +8     
============================================
  Files           616      617       +1     
  Lines         16564    16575      +11     
  Branches       1642     1642              
============================================
+ Hits          15101    15118      +17     
+ Misses         1013     1011       -2     
+ Partials        450      446       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…l/exemplar/ExemplarReservoir.java

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
@jack-berg jack-berg added this to the 1.33.0 milestone Nov 30, 2023
@jack-berg jack-berg modified the milestones: 1.33.0, 1.34.0 Jan 2, 2024
@jack-berg jack-berg merged commit 3449c58 into open-telemetry:main Jan 4, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exemplars for Exponential LongHistogram always have value 0.
2 participants