Test OTLP exporters with different OkHttp versions #6045
Conversation
| @@ -41,6 +39,45 @@ val testJavaVersion: String? by project | |||
|
|
|||
| testing { | |||
| suites { | |||
| listOf( | |||
| "LATEST", | |||
| "4.11.0" | |||
There was a problem hiding this comment.
We would enumerate the list of tested versions here. "LATEST" is a special keyword which just uses the dependency from :dependencyConfiguration.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6045 +/- ##
=========================================
Coverage 91.18% 91.18%
Complexity 5623 5623
=========================================
Files 618 618
Lines 16580 16580
Branches 1642 1642
=========================================
Hits 15118 15118
Misses 1013 1013
Partials 449 449 ☔ View full report in Codecov by Sentry. |
|
Discussed in the 12/14/2023 SIG meeting and there was no disagreement on maintaining these types of tests. Marking as "ready to review". |
| @@ -41,6 +39,45 @@ val testJavaVersion: String? by project | |||
|
|
|||
| testing { | |||
| suites { | |||
| listOf( | |||
| "LATEST", | |||
There was a problem hiding this comment.
does the latest version still get tested outside of this new suite also?
There was a problem hiding this comment.
Indirectly via NoGrpcJavaOtlpIntegrationTest.
But the code for testing the OkHttp based sender was previously in the default test source set. Those test classes have been relocated to testDefaultSender in this PR, which runs as part of these new test suites.
The latest will still always run locally (not just on CI), because of the line further down:
enabled = it.equals("LATEST") || "true".equals(System.getenv("CI"))
There was a problem hiding this comment.
Those test classes have been relocated to testDefaultSender in this PR, which runs as part of these new test suites.
ah, that's what I missed, thx!
A potential solution to #6026.
Allows us to define a set of OkHttp versions to test the OTLP exporters against, besides the latest.
With this, we can tell users who are not satisfied with using the latest OkHttp version that they can downgrade the OkHttp dependency resolution to some other version in the tested set.