Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hasAttributesSatisfying overload to AbstractPointAssert #6048

Conversation

chungngoops
Copy link
Contributor

ref: #6031

Copy link

linux-foundation-easycla bot commented Dec 5, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: chungngoops / name: Chung Nguyen (1710629)

@chungngoops
Copy link
Contributor Author

I created a draft because some tests are failing in my local, I'm checking to make sure my code doesn't make those tests fail.

@chungngoops chungngoops force-pushed the 6031-add-hasAttributesSatisfying-overload branch from 606f421 to 536c9de Compare December 6, 2023 13:25
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3f1b9ed) 91.18% compared to head (1710629) 91.17%.
Report is 13 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6048      +/-   ##
============================================
- Coverage     91.18%   91.17%   -0.01%     
- Complexity     5623     5710      +87     
============================================
  Files           618      628      +10     
  Lines         16580    16725     +145     
  Branches       1642     1650       +8     
============================================
+ Hits          15118    15249     +131     
- Misses         1013     1021       +8     
- Partials        449      455       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chungngoops chungngoops marked this pull request as ready for review December 6, 2023 14:07
@chungngoops chungngoops requested a review from a team December 6, 2023 14:07
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx @chungngoops! can you add a test for this new overload?

@chungngoops
Copy link
Contributor Author

@trask I added tests for that overload similar to other methods in that class, not sure that's enought or should I create a new dedicated test class for it?

Copy link
Member

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chungngoops chungngoops force-pushed the 6031-add-hasAttributesSatisfying-overload branch from 603fd72 to 1710629 Compare December 8, 2023 09:38
@jack-berg jack-berg merged commit 3bb221f into open-telemetry:main Dec 8, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants