Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add connectTimeout configuration option OtlpGrpc{Signal}Exporters #6079

Merged
merged 2 commits into from
Feb 24, 2024

Conversation

jack-berg
Copy link
Member

Followup to #5941 which adds support for OTLP gRPC exporters.

@jack-berg jack-berg requested a review from a team December 15, 2023 23:04
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (8684882) 91.06% compared to head (2ecdd32) 91.06%.

Files Patch % Lines
...er/otlp/logs/OtlpGrpcLogRecordExporterBuilder.java 83.33% 0 Missing and 1 partial ⚠️
...er/otlp/metrics/OtlpGrpcMetricExporterBuilder.java 83.33% 0 Missing and 1 partial ⚠️
...porter/otlp/trace/OtlpGrpcSpanExporterBuilder.java 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #6079   +/-   ##
=========================================
  Coverage     91.06%   91.06%           
- Complexity     5671     5678    +7     
=========================================
  Files           620      620           
  Lines         16553    16577   +24     
  Branches       1689     1692    +3     
=========================================
+ Hits          15074    15096   +22     
+ Misses          993      992    -1     
- Partials        486      489    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jack-berg
Copy link
Member Author

@open-telemetry/java-approvers PTAL. This should be straight forward to review / merge.

Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies on the time taken to get to reviewing this. 😓

This seems like a very welcome addition....kinda surprising it hasn't been more often requested tbh. Just had the one question about zero, but looks good otherwise.

@jkwatson jkwatson merged commit 1d4a2f4 into open-telemetry:main Feb 24, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants