Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define CODECOV token #6186

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Conversation

jack-berg
Copy link
Member

See @trask's comment here: #6183 (comment)

As of codecov 4.0.0:

Tokenless uploading is unsupported. However, PRs made from forks to the upstream public repos will support tokenless (e.g. contributors to OS projects do not need the upstream repo's Codecov token). This doc shows instructions on how to add the Codecov token.

My read of this is that builds for this repo will need the token to upload, but PRs from forks don't need it.

@jack-berg jack-berg requested a review from a team February 1, 2024 22:52
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e9266c8) 91.06% compared to head (ffb41ad) 91.06%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #6186   +/-   ##
=========================================
  Coverage     91.06%   91.06%           
  Complexity     5672     5672           
=========================================
  Files           620      620           
  Lines         16560    16560           
  Branches       1690     1690           
=========================================
  Hits          15081    15081           
  Misses          993      993           
  Partials        486      486           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jack-berg jack-berg merged commit 2d74bf2 into open-telemetry:main Feb 5, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants