Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename opentelemetry-extension-incubator to opentelemetry-api-incubator, merge opentelemetry-api-events #6289

Merged
merged 3 commits into from
Mar 21, 2024

Conversation

jack-berg
Copy link
Member

@jack-berg jack-berg commented Mar 12, 2024

Resolves #6121. Summary of changes:

  • BREAKING: Rename io.opentelemetry:opentelemetry-extension-incubator to io.opentelemetry:opentelemetry-api-incubator
  • BREAKING: Rename packages io.opentelemetry.extension.incubator.* to io.opentelemetry.api.incubator
  • BREAKING: Stop publishing io.opentelemetry:opentelemetry-api-event. Merge contents into io.opentelemetry:opentelemetry-api-incubator.
  • BREAKING: Rename package io.opentelemetry.api.events to io.opentelemetry.api.incubator.events

Part of the goal of bundling several breaking changes into a single release to reduce churn.

cc @breedx-splk

@jack-berg jack-berg requested a review from a team March 12, 2024 19:57
@@ -7,7 +7,7 @@ plugins {
}

description = "OpenTelemetry API Incubator"
otelJava.moduleName.set("io.opentelemetry.extension.incubator")
otelJava.moduleName.set("io.opentelemetry.api.incubator")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package changes as well.

@jack-berg
Copy link
Member Author

I considered making an equivalent change to rename opentelemetery-sdk-extension-incubator to opentelemetry-sdk-incubator, but realized that opentelemetry-sdk-extension-incubator is different in that it actually does incubate SDK extensions, not just SDK code. For example, it incubates view file config and file config, both of which are autoconfigure extensions.

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.06%. Comparing base (34b64b1) to head (8a743ba).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6289      +/-   ##
============================================
+ Coverage     91.04%   91.06%   +0.02%     
- Complexity     5726     5729       +3     
============================================
  Files           625      625              
  Lines         16744    16744              
  Branches       1713     1713              
============================================
+ Hits          15244    15248       +4     
+ Misses         1006     1003       -3     
+ Partials        494      493       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jack-berg
Copy link
Member Author

FYI, if we can't get this PR and a followup to be able to define event payloads in the log record body in time for the next release, I think we need to revert #6253.

Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I support this. Sorry about the delay in getting it rubber stamped....kubecon timing is a little tricky. I hope we can still get the remaining event stuff in! 🤞🏻

@jack-berg
Copy link
Member Author

@open-telemetry/java-approvers I'll merge this tomorrow if there are no additional comments. Need to keep moving on this to bundle all the changes w/ churn in time for the next release.

@jack-berg jack-berg merged commit 44c69ea into open-telemetry:main Mar 21, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge opentelemetry-api-events into opentelemetry-extension-incubator
2 participants