Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional API incubator docs #6356

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

jack-berg
Copy link
Member

I've responded to several questions lately about how to use various incubating API features, and the only thing I can respond with is a link to the PR where the feature was added.

This PR adds little blurbs of code which demonstrate simple usage patterns of the experimental API features. The code is put in test classes so we can verify it compiles and that the minimal set of assertions work. The incubator API readme links to these usage test classes.

With this, we can funnel anyone interested to the incubator readme and they should be able to self-help most of the time.

Once a particular feature is stable, we can delete these usage tests and consider moving the documentation to opentelemetry.io. In an experimental state, there's too great an opportunity for breaking API changes and drift between static opentelemetry.io content.

@jack-berg jack-berg requested a review from a team April 5, 2024 21:24
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.09%. Comparing base (1f80fe8) to head (6831cc9).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #6356   +/-   ##
=========================================
  Coverage     91.09%   91.09%           
  Complexity     5772     5772           
=========================================
  Files           627      627           
  Lines         16852    16852           
  Branches       1720     1720           
=========================================
  Hits          15351    15351           
  Misses         1006     1006           
  Partials        495      495           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

"io.opentelemetry.contrib:opentelemetry-aws-xray-propagator:1.29.0-alpha",
"io.opentelemetry.semconv:opentelemetry-semconv:1.21.0-alpha",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"io.opentelemetry.semconv:opentelemetry-semconv:1.21.0-alpha",
"io.opentelemetry.semconv:opentelemetry-semconv:1.24.0-alpha",

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better yet, don't make that change, I'll send a PR so renovate will update it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jack-berg jack-berg merged commit 572606a into open-telemetry:main Apr 8, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants