Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load file config YAML using core schema, ensure that env var substiut… #6436

Merged
merged 3 commits into from
May 20, 2024

Conversation

jack-berg
Copy link
Member

@jack-berg jack-berg commented May 8, 2024

Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 80.43478% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 90.86%. Comparing base (7953048) to head (c3de11e).

Files Patch % Lines
...ension/incubator/fileconfig/FileConfiguration.java 80.43% 7 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6436      +/-   ##
============================================
- Coverage     90.90%   90.86%   -0.04%     
  Complexity     6169     6169              
============================================
  Files           678      678              
  Lines         18484    18507      +23     
  Branches       1813     1818       +5     
============================================
+ Hits          16802    16817      +15     
- Misses         1147     1154       +7     
- Partials        535      536       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is great. I had a few nitpick/small comments, but good work overall. 🥂

List<NodeTuple> nodeValue = node.getValue();
for (NodeTuple tuple : nodeValue) {
Node keyNode = tuple.getKeyNode();
Node valueNode = tuple.getValueNode();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe move the valueNode down closer to where it's used.

@jack-berg jack-berg merged commit c71c4d9 into open-telemetry:main May 20, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants