Start prometheus httpserver with daemon thread #6472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6472 +/- ##
============================================
- Coverage 90.87% 90.87% -0.01%
Complexity 6169 6169
============================================
Files 678 678
Lines 18507 18508 +1
Branches 1818 1818
============================================
Hits 16819 16819
Misses 1153 1153
- Partials 535 536 +1 ☔ View full report in Codecov by Sentry. |
laurit
approved these changes
May 23, 2024
jack-berg
approved these changes
May 23, 2024
jack-berg
reviewed
May 23, 2024
...ters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/PrometheusHttpServer.java
Show resolved
Hide resolved
jack-berg
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to use daemon thread for scheduling in jmx-metrics BeanFinder, the Prometheus HTTP server should also be started with daemon thread. Perhaps all threads created by the agent should be daemon in principle?
The pr #6464 can solve part of the problem (please refer Start Prometheus HTTP server on the provided executor), and this pr will solve the rest.