fix: fix timeout in aws resource detector (#2186)

* fix: fix timeout in aws resource detector Current timeout is 1 sec, which is causing EC2 metadata api request timed out. Increase the timeout to 5 sec. * Updated the timeouts as per comments --------- Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
open-telemetry · Jun 13, 2024 · 9e4726c · 9e4726c
1 parent caf7cb5
commit 9e4726c
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 11 deletions.
diff --git a/detectors/node/opentelemetry-resource-detector-aws/src/detectors/AwsEc2Detector.ts b/detectors/node/opentelemetry-resource-detector-aws/src/detectors/AwsEc2Detector.ts
@@ -131,7 +131,7 @@ class AwsEc2Detector implements Detector {
       const timeoutId = setTimeout(() => {
         req.abort();
         reject(new Error('EC2 metadata api request timed out.'));
-      }, 1000);
+      }, this.MILLISECOND_TIME_OUT);
 
       const req = http.request(options, res => {
         clearTimeout(timeoutId);

diff --git a/detectors/node/opentelemetry-resource-detector-aws/test/detectors/AwsEc2Detector.test.ts b/detectors/node/opentelemetry-resource-detector-aws/test/detectors/AwsEc2Detector.test.ts
@@ -109,7 +109,8 @@ describe('awsEc2Detector', () => {
       scope.done();
     });
 
-    it('should throw when timed out', async () => {
+    it('should throw when timed out', function (done) {
+      this.timeout(6000);
       const expectedError = new Error('EC2 metadata api request timed out.');
       const scope = nock(AWS_HOST)
         .put(AWS_TOKEN_PATH)
@@ -120,17 +121,21 @@ describe('awsEc2Detector', () => {
         .reply(200, () => mockedIdentityResponse)
         .get(AWS_HOST_PATH)
         .matchHeader(AWS_METADATA_TOKEN_HEADER, mockedTokenResponse)
-        .delayConnection(2000)
+        .delayConnection(5000)
         .reply(200, () => mockedHostResponse);
 
-      try {
-        await awsEc2Detector.detect();
-        assert.ok(false, 'Expected to throw');
-      } catch (err) {
-        assert.deepStrictEqual(err, expectedError);
-      }
-
-      scope.done();
+      awsEc2Detector
+        .detect()
+        .then(() => {
+          assert.ok(false, 'Expected to throw');
+        })
+        .catch(err => {
+          assert.deepStrictEqual(err, expectedError);
+        })
+        .finally(() => {
+          scope.done();
+          done();
+        });
     });
 
     it('should throw when replied with an Error', async () => {