fix: fix timeout in aws resource detector #2186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current timeout is 1 sec, which is causing EC2 metadata api request timed out. Increase the timeout to 5 sec.
maryliag
reviewed
May 10, 2024
| @@ -109,7 +109,8 @@ describe('awsEc2Detector', () => { | |||
| scope.done(); | |||
| }); | |||
|
|
|||
| it('should throw when timed out', async () => { | |||
| it('should throw when timed out', function (done) { | |||
| this.timeout(7000); | |||
There was a problem hiding this comment.
if you're changing the timeout value for the test, you're not really testing the new value you changed to. Don't you want to test with the 5s?
There was a problem hiding this comment.
Updated the timeouts
blumamir
approved these changes
May 18, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2186 +/- ##
==========================================
- Coverage 90.97% 90.40% -0.58%
==========================================
Files 146 149 +3
Lines 7492 7514 +22
Branches 1502 1573 +71
==========================================
- Hits 6816 6793 -23
- Misses 676 721 +45
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current timeout is 1 sec, which is causing EC2 metadata api request timed out
Which problem is this PR solving?
The current Ec2 metadata API timeout is 1 sec, which is causing frequent "EC2 metadata API request timed out" issues.
Short description of the changes
Increased the metadata API timeout to 5 sec.