You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I guess there needs to be some more checking there, and/or some fallback behavior if layer.name is empty 🤔
The app that triggers this span is basically:
constKoa=require('koa');constRouter=require('@koa/router');constapp1=newKoa();router1.get('/test-transaction',ctx=>{// do something here...ctx.body={};});app1.use(router1.routes()).use(router1.allowedMethods());app1.listen(port1);
This ensures we have correct op, name & origin for all koa middleware
spans.
I also updated the E2E test to actually check this as well.
I also noticed a problem in the instrumentation where the name is
sometimes empty here, opened an upstream issue:
open-telemetry/opentelemetry-js-contrib#2220
to look into this.
We are seeing some spans emitted by the koa instrumentation that look like this:
Which I guess comes from here: https://github.com/open-telemetry/opentelemetry-js-contrib/blob/main/plugins/node/opentelemetry-instrumentation-koa/src/utils.ts#L43
I guess there needs to be some more checking there, and/or some fallback behavior if
layer.name
is empty 🤔The app that triggers this span is basically:
And then visiting
/test-transaction
.Note that the router span seems correct:
The text was updated successfully, but these errors were encountered: