Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update core dependencies stable ^1.3.1 experimental ^0.29.2 #1042

Merged
merged 9 commits into from
Jun 8, 2022
Merged

chore: update core dependencies stable ^1.3.1 experimental ^0.29.2 #1042

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1ee76a1
chore(test-utils): pin dev dependencies to across the repo
May 30, 2022
a2d7bfa
chore: upgrade all dependencies to core 1.3.0/0.29.0
May 30, 2022
917ee5b
fix(host-metrics): fix build with new api
May 30, 2022
b6d205c
fix(host-metrics): fix tests
May 30, 2022
373e8a0
Merge branch 'main' into test-utils-pin-versions
rauno56 Jun 2, 2022
386115d
Merge remote-tracking branch 'upstream/main' into test-utils-pin-vers…
Jun 8, 2022
96408a7
chore: use core caret ^0.29.2 and ^1.3.1
Jun 8, 2022
bfdb4cf
Merge branch 'test-utils-pin-versions' of github.com:blumamir/opentel…
Jun 8, 2022
84a97a9
fix: forgotten version
Jun 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/opentelemetry-test-utils/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,11 @@
},
"dependencies": {
"@opentelemetry/core": "^1.0.0",
"@opentelemetry/exporter-jaeger": "^1.0.0",
"@opentelemetry/exporter-jaeger": "1.2.0",
"@opentelemetry/instrumentation": "^0.28.0",
"@opentelemetry/sdk-trace-node": "^1.0.0",
"@opentelemetry/resources": "^1.0.0",
"@opentelemetry/sdk-trace-base": "^1.0.0",
"@opentelemetry/sdk-trace-node": "1.2.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should we pin an old version?
Such pinning caused a lot problems in previous releases that new SDK was unusable with instrumentations from contrib.

And if pinning is the way to go - why not @opentelemetry/instrumentation?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should we pin an old version?

That is not an old version, but the version that the entire monorepo is aligned to currently in master.
The CI fails because we mix versions 1.2.0 and 1.3.0 since some of them are pinned in instrumentation dev dep, and others are introduced via transitive dependency on the caret range (like in the fix mentioned above).
I think we should thrive to have the same version everywhere when building and testing contrib.

Such pinning caused a lot problems in previous releases that new SDK was unusable with instrumentations from contrib.

I only changed the test-utils package which is a dev dependency, so to my understanding, it should not affect any usage for users which consume the released packages.

And if pinning is the way to go - why not @opentelemetry/instrumentation

Since instrumentations depend on it with caret, so I wanted to be align to make sure we pull the same version everywhere

"@opentelemetry/resources": "1.2.0",
"@opentelemetry/sdk-trace-base": "1.2.0",
"@opentelemetry/semantic-conventions": "^1.0.0"
}
}