chore(tedious): support new tedious versions 15, 16 #1638
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaces: #1521
When the tedious instrumentations was written, the latest version was 14.
Since then,
tedious
package released versions 15 and 16, for which renovate opened to following PRs: #1403 #1521 .So it turns out that tedious is already compatible and patches new versions. This PR is only about aligning the supported versions and update the tests to use new tedious versions.
Prior to this PR, the instrumentation was patching version range
*
, which isn't very safe as new major versions can introduce breaking changes which the instrumentation might not be ready for.This PR replaces the unmergable renovate PR, by introducing the following changes:
*
. This algins the instrumentation to the practice which is common in this repo and safer.tav
for node 14, as the new versions dropped support for it which obviously fails to install in node 14.npm run test
to use the most downloaded version which is not 16 (which dropped support for node 14) -15.1.3
, and the"@types/tedious"
to latest -^4.0.9
As I am using a mac with apple chip, for which the
mcr.microsoft.com/mssql/server:2017-latest
docker image has no compatible distribution, I am not able to run the unit-tests locally, so uploading it here to test on CI. If you are aware of a better workflow, please let me know.