Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ioredis): fix instrumentation of ESM-imported ioredis #1694

Merged
merged 6 commits into from
Oct 17, 2023

Commits on Sep 21, 2023

  1. fix(ioredis): fix instrumentation of ESM-imported ioredis

    - With an ESM import the top-level object is a Module Namespace Object
      (https://tc39.es/ecma262/#sec-module-namespace-objects) that has no
      prototype. For compat, Node.js assigns the usual CommonJS
      module.exports to `<module>.default`, so use that when this is
      an ESM module.
    - Also, TypeScript translates class properties to assignments in the
      constructor after the super() call. Because super() can call init()
      and enable() synchronously, it calls back into
      'IORedisInstrumentation' before 'traceSendCommand' was defined.
      Defining it as a method fixes that issue.
    
    Fixes: open-telemetry#1692
    trentm committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    62a1456 View commit details
    Browse the repository at this point in the history
  2. eslint style fix

    trentm committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    7bff58b View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2023

  1. Configuration menu
    Copy the full SHA
    faea55c View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. Configuration menu
    Copy the full SHA
    fa28a93 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2023

  1. Configuration menu
    Copy the full SHA
    cc31725 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2023

  1. Configuration menu
    Copy the full SHA
    f6e6414 View commit details
    Browse the repository at this point in the history