Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow redis version 3.0.0 and above #215

Merged
merged 1 commit into from
Oct 6, 2020

Conversation

akshah123
Copy link
Contributor

Which problem is this PR solving?

Support version 3.x of redis.

Short description of the changes

This could resolve issue #214

@akshah123 akshah123 requested a review from a team October 6, 2020 03:55
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 6, 2020

CLA Check
The committers are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Oct 6, 2020

Codecov Report

Merging #215 into master will increase coverage by 0.59%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #215      +/-   ##
==========================================
+ Coverage   94.56%   95.16%   +0.59%     
==========================================
  Files          83       88       +5     
  Lines        4088     4651     +563     
  Branches      430      482      +52     
==========================================
+ Hits         3866     4426     +560     
- Misses        222      225       +3     
Impacted Files Coverage Δ
...ors/opentelemetry-propagator-jaeger/src/version.ts
...ators/opentelemetry-propagator-jaeger/.eslintrc.js
...propagator-jaeger/src/JaegerHttpTracePropagator.ts
...ator-jaeger/test/JaegerHttpTracePropagator.test.ts
...de/opentelemetry-hapi-instrumentation/src/types.ts 100.00% <0.00%> (ø)
...entelemetry-hapi-instrumentation/test/hapi.test.ts 100.00% <0.00%> (ø)
...ode/opentelemetry-hapi-instrumentation/src/hapi.ts 98.43% <0.00%> (ø)
...-hapi-instrumentation/test/hapi-server-ext.test.ts 100.00% <0.00%> (ø)
...ode/opentelemetry-hapi-instrumentation/.mocharc.js 60.00% <0.00%> (ø)
.../opentelemetry-hapi-instrumentation/src/version.ts 100.00% <0.00%> (ø)
... and 3 more

@vmarchaud
Copy link
Member

@dyladan dyladan added the enhancement New feature or request label Oct 6, 2020
@obecny obecny merged commit 807346b into open-telemetry:master Oct 6, 2020
@akshah123 akshah123 deleted the patch-1 branch October 6, 2020 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants