fix(koa)!: use generic config hook types and move dep to dev #2303
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2228
This PR aims to remove the instrumentation package dependency on the koa types packages, by making the relevant types generic and defaulting to
any
. That allows users who choose to implement the hook, to either use typeany
, or install the relevant types packages and populate the generic parameters.d.ts
files transitively imported fromindex.d.ts
do not import types from@types/koa
,@types/koa__router
or any other dev dependencyBreaking Change
KoaContext
is no longer exported as public type from the packageany
by default, which should not break anyone I believe, but will no not verified this variable typing as before.Prior Art
defaults to any and allow to use generics to type correctly:
vendors part of the type as default, but allows to specify the full type when desired: