feat(detector-gcp)!: change implementation to DetectorSync interface #2335
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Another PR moving away from the deprecated
Detector
interface in order to prepare the codebase for a fix for #2320. This time is forGCP
detector.Not doing all detectors at once:
My reasons to do this change:
detectResources
from@opentelemetry/resources
package. RefShort description of the changes
detect
method to be sync