-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(detector-github)!: change implementation to DetectorSync interface #2336
feat(detector-github)!: change implementation to DetectorSync interface #2336
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2336 +/- ##
==========================================
- Coverage 90.97% 90.40% -0.58%
==========================================
Files 146 149 +3
Lines 7492 7359 -133
Branches 1502 1527 +25
==========================================
- Hits 6816 6653 -163
- Misses 676 706 +30
|
This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature. |
This issue was closed because no owner or sponsor has been found after 14 days |
I'll sponsor this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating this 👍
(changed the title to reflect that this is a breaking change 🙂) |
@pichlermarc FYI: David was going to bring up some Qs regarding all the Detector -> DetectorSync PRs in the JS SIG tomorrow. There is some more discussion on #2328 |
For the record the SIG we agreed to break for non stable detectors like this one. So I'm merging this one when I can |
Context
Another PR moving away from the deprecated
Detector
interface in order to prepare the codebase for a fix for #2320. this time is forGitHub
detector.Not doing all detectors at once:
My reasons to categorize it as a refactor are:
detectResources
from@opentelemetry/resources
package. RefShort description of the changes
detect
method to be sync