Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auto-instrumentations-node): enable auto-instrumentation for KafkaJS #2340

Merged

Conversation

@brianphillips brianphillips requested a review from a team as a code owner July 15, 2024 22:02
Copy link

linux-foundation-easycla bot commented Jul 15, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: blumamir / name: Amir Blum (7222355, 4a08f51)
  • ✅ login: brianphillips / name: Brian Phillips (f3cd81c)

@trentm
Copy link
Contributor

trentm commented Jul 17, 2024

@brianphillips Are you able to sign the CLA? See the comment above this one.

@trentm
Copy link
Contributor

trentm commented Jul 17, 2024

Note that the intent when adding instrumentation-kafkajs a number of weeks ago was to eventually add it to auto-instruemtnations-node: #2089 (comment)

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.39%. Comparing base (dfb2dff) to head (4a08f51).
Report is 192 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2340      +/-   ##
==========================================
- Coverage   90.97%   90.39%   -0.59%     
==========================================
  Files         146      149       +3     
  Lines        7492     7371     -121     
  Branches     1502     1532      +30     
==========================================
- Hits         6816     6663     -153     
- Misses        676      708      +32     
Files Coverage Δ
...tapackages/auto-instrumentations-node/src/utils.ts 98.19% <100.00%> (-0.59%) ⬇️

... and 64 files with indirect coverage changes

@brianphillips
Copy link
Contributor Author

@trentm I'm waiting on our corporate legal counsel to figure out how to sign the CCLA. I'll check in again (they tried earlier this week and weren't able to gain access and opened a ticket? I'm not really sure...)

@brianphillips
Copy link
Contributor Author

@trentm ok, we should be good to go

@blumamir blumamir merged commit 8302464 into open-telemetry:main Jul 23, 2024
19 checks passed
@dyladan dyladan mentioned this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment