-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(auto-instrumentations-node): enable auto-instrumentation for KafkaJS #2340
feat(auto-instrumentations-node): enable auto-instrumentation for KafkaJS #2340
Conversation
@brianphillips Are you able to sign the CLA? See the comment above this one. |
Note that the intent when adding instrumentation-kafkajs a number of weeks ago was to eventually add it to auto-instruemtnations-node: #2089 (comment) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2340 +/- ##
==========================================
- Coverage 90.97% 90.39% -0.59%
==========================================
Files 146 149 +3
Lines 7492 7371 -121
Branches 1502 1532 +30
==========================================
- Hits 6816 6663 -153
- Misses 676 708 +32
|
@trentm I'm waiting on our corporate legal counsel to figure out how to sign the CCLA. I'll check in again (they tried earlier this week and weren't able to gain access and opened a ticket? I'm not really sure...) |
@trentm ok, we should be good to go |
Which problem is this PR solving?
Short description of the changes
@opentelemetry/instrumentation-kafkajs
to the@opentelemetry/auto-instrumentations-node
meta package