Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(instr-tedious): support tedious@19 #2401

Merged
merged 1 commit into from
Aug 26, 2024
Merged

feat(instr-tedious): support tedious@19 #2401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions plugins/node/instrumentation-tedious/.tav.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,3 +24,10 @@ tedious:
# TypeScript v5 to use. This peerDependencies can be removed when this
# package updates to TypeScript v5.
peerDependencies: typescript@5
- versions:
include: ">=19 <20"
mode: latest-majors
node: '>=18.17'
commands: npm run test
# See typescript@5 note above.
peerDependencies: typescript@5
2 changes: 1 addition & 1 deletion plugins/node/instrumentation-tedious/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ npm install --save @opentelemetry/instrumentation-tedious

## Supported Versions

- [tedious](https://www.npmjs.com/package/tedious) `>=1.11.0 <19`
- [tedious](https://www.npmjs.com/package/tedious) `>=1.11.0 <20`

## Usage

Expand Down
2 changes: 1 addition & 1 deletion plugins/node/instrumentation-tedious/src/instrumentation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ export class TediousInstrumentation extends InstrumentationBase<TediousInstrumen
return [
new InstrumentationNodeModuleDefinition(
TediousInstrumentation.COMPONENT,
['>=1.11.0 <19'],
['>=1.11.0 <20'],
(moduleExports: typeof tedious) => {
const ConnectionPrototype: any = moduleExports.Connection.prototype;
for (const method of PATCHED_METHODS) {
Expand Down
6 changes: 5 additions & 1 deletion plugins/node/instrumentation-tedious/test/instrumentation.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,11 @@ const incompatVersions =
(semver.lt(processVersion, '15.0.0') &&
semver.gte(tediousVersion, '16.0.0')) ||
// tedious@17 removed support for node v16 and v19 https://github.com/tediousjs/tedious/releases/tag/v17.0.0
(semver.lt(processVersion, '17.0.0') && semver.gte(tediousVersion, '17.0.0'));
(semver.lt(processVersion, '17.0.0') &&
semver.gte(tediousVersion, '17.0.0')) ||
// tedious@19 removed support for node <18.17.0 https://github.com/tediousjs/tedious/releases/tag/v19.0.0
(semver.lt(processVersion, '18.17.0') &&
semver.gte(tediousVersion, '19.0.0'));

describe('tedious', () => {
let tedious: any;
Expand Down