Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(detector-alibaba): suppres internal tracing #2429

Conversation

david-luna
Copy link
Contributor

Which problem is this PR solving?

  • this detector performs some request to get metadata from Alibaba cloud. We should suppress the tracing for these requests

ref: #2320

Short description of the changes

  • suppress tracing when resolving attributes
  • add test

@david-luna david-luna requested a review from a team September 12, 2024 08:40
@@ -56,7 +56,7 @@
"@opentelemetry/api": "^1.0.0"
},
"dependencies": {
"@opentelemetry/resources": "^1.0.0",
"@opentelemetry/resources": "^1.10.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note for reviewer: DetectorSync interface appeared in v1.10.0. this is a leftover from #2328

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.71%. Comparing base (dfb2dff) to head (588237c).
Report is 238 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2429      +/-   ##
==========================================
- Coverage   90.97%   90.71%   -0.26%     
==========================================
  Files         146      156      +10     
  Lines        7492     7671     +179     
  Branches     1502     1578      +76     
==========================================
+ Hits         6816     6959     +143     
- Misses        676      712      +36     
Files with missing lines Coverage Δ
...aba-cloud/src/detectors/AlibabaCloudEcsDetector.ts 97.95% <100.00%> (+0.28%) ⬆️

... and 76 files with indirect coverage changes

Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@legendecas legendecas merged commit 9a7690e into open-telemetry:main Sep 12, 2024
21 checks passed
@dyladan dyladan mentioned this pull request Sep 12, 2024
@david-luna david-luna deleted the dluna/2320-alibaba-detector-suppress-tracing branch September 23, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants