-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(detector-alibaba): suppres internal tracing #2429
fix(detector-alibaba): suppres internal tracing #2429
Conversation
@@ -56,7 +56,7 @@ | |||
"@opentelemetry/api": "^1.0.0" | |||
}, | |||
"dependencies": { | |||
"@opentelemetry/resources": "^1.0.0", | |||
"@opentelemetry/resources": "^1.10.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note for reviewer: DetectorSync
interface appeared in v1.10.0
. this is a leftover from #2328
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2429 +/- ##
==========================================
- Coverage 90.97% 90.71% -0.26%
==========================================
Files 146 156 +10
Lines 7492 7671 +179
Branches 1502 1578 +76
==========================================
+ Hits 6816 6959 +143
- Misses 676 712 +36
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Which problem is this PR solving?
ref: #2320
Short description of the changes