-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(examples/mysql): modernize this example #2465
Conversation
- drop Jaeger from examples (given open-telemetry/opentelemetry-specification#3551) - update otel-collector-contib version and switch from logging to debug exporter (lifted from open-telemetry#2441) - various other small fixes to get the README steps basically working
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2465 +/- ##
=======================================
Coverage 90.74% 90.74%
=======================================
Files 156 156
Lines 7723 7723
Branches 1588 1588
=======================================
Hits 7008 7008
Misses 715 715 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with a small nit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @trentm 👍🏻
…a multiarch image with support for arm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if the examples should also use the NodeSDK
Personally, I think so, but that's a separate discussion that I don't want to re-litigate here. I looked briefly, but I don't recall where that earlier discussion was. I thought I'd opened an issue to suggest changing over docs/examples to prefer using NodeSDK, but I cannot find it now. |
Refs: #2441
@codeboten This builds on your #2441 changes and does other modernization to examples/mysql/... to get it to, at least basically, work.