Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples/mysql): modernize this example #2465

Merged
merged 4 commits into from
Oct 11, 2024

Conversation

trentm
Copy link
Contributor

@trentm trentm commented Oct 8, 2024

Refs: #2441


@codeboten This builds on your #2441 changes and does other modernization to examples/mysql/... to get it to, at least basically, work.

- drop Jaeger from examples (given open-telemetry/opentelemetry-specification#3551)
- update otel-collector-contib version and switch from logging to debug exporter (lifted from open-telemetry#2441)
- various other small fixes to get the README steps basically working
@trentm trentm self-assigned this Oct 8, 2024
@trentm trentm requested a review from a team as a code owner October 8, 2024 22:34
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.74%. Comparing base (d08d50d) to head (03ffc25).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2465   +/-   ##
=======================================
  Coverage   90.74%   90.74%           
=======================================
  Files         156      156           
  Lines        7723     7723           
  Branches     1588     1588           
=======================================
  Hits         7008     7008           
  Misses        715      715           

Copy link
Contributor

@raphael-theriault-swi raphael-theriault-swi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with a small nit.

examples/mysql/docker/docker-compose.yaml Outdated Show resolved Hide resolved
Copy link

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @trentm 👍🏻

Copy link
Contributor

@david-luna david-luna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if the examples should also use the NodeSDK

@trentm
Copy link
Contributor Author

trentm commented Oct 11, 2024

I wonder if the examples should also use the NodeSDK

Personally, I think so, but that's a separate discussion that I don't want to re-litigate here. I looked briefly, but I don't recall where that earlier discussion was. I thought I'd opened an issue to suggest changing over docs/examples to prefer using NodeSDK, but I cannot find it now.

@trentm trentm merged commit d11efb3 into open-telemetry:main Oct 11, 2024
16 checks passed
@trentm trentm deleted the tm-update-examples-mysql branch October 11, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants