Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update contributing guidelines for required org membership #2548

Conversation

JamieDanielson
Copy link
Member

@JamieDanielson JamieDanielson commented Nov 25, 2024

Which problem is this PR solving?

It should be easier to auto-assign issues and PRs and grant more authority to codeowners on specific packages.
This came up while reviewing the react-native instrumentation, which is currently the top requested feature in the repo. We want to delegate responsibly, while still keeping a high bar for adding instrumentations.

Short description of the changes

Update contributing guidelines to

@JamieDanielson JamieDanielson requested a review from a team as a code owner November 25, 2024 17:26
@JamieDanielson JamieDanielson requested a review from a team November 25, 2024 17:29
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.80%. Comparing base (23a345d) to head (a68a2af).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2548      +/-   ##
==========================================
+ Coverage   90.75%   90.80%   +0.04%     
==========================================
  Files         169      169              
  Lines        8026     8026              
  Branches     1635     1635              
==========================================
+ Hits         7284     7288       +4     
+ Misses        742      738       -4     

see 1 file with indirect coverage changes

@trentm
Copy link
Contributor

trentm commented Nov 25, 2024

Isn't https://github.com/open-telemetry/opentelemetry-js-contrib/blob/main/.github/workflows/component-owners.yml already meant to be handling assigning PRs to and/or request reviews from component owners?

From https://github.com/dyladan/component-owners#readme

Automatically add component owners as assignees and approvers to pull requests.

This works very similarly to CODEOWNERS, however with CODEOWNERS all owners must have write access to the repository. ...

@pichlermarc
Copy link
Member

This works very similarly to CODEOWNERS, however with CODEOWNERS all owners must have write access to the repository. ...

Aah, yes I completely forgot about this 🤦 CODEOWNERS does not work with non-write permission owners. 😞

Anyway I think we can still do something similar with component-owners.yaml and since we will give owners triage permissions they can then apply a label that a PR is ready to merge. Then approvers/maintainers can just swoop in and merge the PR. 🙂

@JamieDanielson
Copy link
Member Author

@trentm @pichlermarc I removed the references to CODEOWNERS and just kept in the triagers role and the requirement of being in otel org.

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for updating this and for going through the process or requesting the creation contrib triagers role 🙂

@pichlermarc pichlermarc merged commit 5d60689 into open-telemetry:main Dec 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants