Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(aws-sdk): set v3 versions based on Node.js support #2628

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Jan 7, 2025

Which problem is this PR solving?

Short description of the changes

  • Sets AWS SDK for JavaScript v3 versions based on Node.js version they support.

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.78%. Comparing base (d4d3c4f) to head (44953c0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2628   +/-   ##
=======================================
  Coverage   90.78%   90.78%           
=======================================
  Files         169      169           
  Lines        8056     8056           
  Branches     1643     1643           
=======================================
  Hits         7314     7314           
  Misses        742      742           

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for tracking that down, much appreciated 🙌

@pichlermarc pichlermarc merged commit 12ee8db into open-telemetry:main Jan 8, 2025
20 checks passed
@trivikr trivikr deleted the aws-sdk-node-end-of-life branch January 8, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[aws-sdk] test-all-versions script is failing
4 participants