Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(instrumentation-aws-lambda): do not import from semantic-conventions incubating entry-point #2670

Conversation

trentm
Copy link
Contributor

@trentm trentm commented Jan 18, 2025

@trentm trentm self-assigned this Jan 18, 2025
@trentm trentm requested a review from a team as a code owner January 18, 2025 01:10
@github-actions github-actions bot requested a review from jj22ee January 18, 2025 01:10
@trentm trentm mentioned this pull request Jan 18, 2025
1 task
Copy link

codecov bot commented Jan 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.80%. Comparing base (4fb610d) to head (5982a41).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2670   +/-   ##
=======================================
  Coverage   90.80%   90.80%           
=======================================
  Files         170      171    +1     
  Lines        8070     8071    +1     
  Branches     1646     1646           
=======================================
+ Hits         7328     7329    +1     
  Misses        742      742           
Files with missing lines Coverage Δ
...-instrumentation-aws-lambda/src/instrumentation.ts 94.52% <100.00%> (ø)
...elemetry-instrumentation-aws-lambda/src/semconv.ts 100.00% <100.00%> (ø)

@pichlermarc pichlermarc added the has:owner-approval Approved by Component Owner label Jan 20, 2025
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(approving due to owner-approval)

@pichlermarc pichlermarc merged commit 0db649f into open-telemetry:main Jan 20, 2025
22 checks passed
@dyladan dyladan mentioned this pull request Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants