Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(host-metrics): upgrade api-metrics to v0.28.0 #990

Merged
merged 3 commits into from
May 5, 2022

Conversation

legendecas
Copy link
Member

@legendecas legendecas commented Apr 29, 2022

Which problem is this PR solving?

  • Upgrade @opentelemetry/api-metrics and @opentelemetry/sdk-metrics-base to v0.28.0 in host-metrics.

Short description of the changes

  • Claim package owner, /cc @obecny.
  • Now that the metrics collection is determinist with metricReader.collect (collect whenever it is needed), refactor the tests to be more deterministic without fake timers.

Checklist

  • Ran npm run test-all-versions for the edited package(s) on the latest commit if applicable.

@legendecas legendecas requested a review from a team April 29, 2022 09:00
@legendecas legendecas mentioned this pull request Apr 29, 2022
1 task
@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #990 (9e9cf96) into main (2ea76cc) will increase coverage by 0.33%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #990      +/-   ##
==========================================
+ Coverage   95.91%   96.24%   +0.33%     
==========================================
  Files          13       19       +6     
  Lines         856     1013     +157     
  Branches      178      188      +10     
==========================================
+ Hits          821      975     +154     
- Misses         35       38       +3     
Impacted Files Coverage Δ
...ages/opentelemetry-host-metrics/src/BaseMetrics.ts 100.00% <100.00%> (ø)
packages/opentelemetry-host-metrics/src/metric.ts 100.00% <100.00%> (ø)
packages/opentelemetry-host-metrics/src/util.ts 91.66% <0.00%> (ø)
packages/opentelemetry-host-metrics/src/enum.ts 100.00% <0.00%> (ø)
...ackages/opentelemetry-host-metrics/src/stats/si.ts 66.66% <0.00%> (ø)
...ges/opentelemetry-host-metrics/src/stats/common.ts 100.00% <0.00%> (ø)

@Flarna Flarna mentioned this pull request May 4, 2022
@rauno56 rauno56 merged commit 669d34b into open-telemetry:main May 5, 2022
@legendecas legendecas deleted the host-metrics branch May 5, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants