Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use context to stop tracing #1040

Closed
dyladan opened this issue May 8, 2020 · 4 comments · Fixed by #1344
Closed

Use context to stop tracing #1040

dyladan opened this issue May 8, 2020 · 4 comments · Fixed by #1344
Assignees

Comments

@dyladan
Copy link
Member

dyladan commented May 8, 2020

There is a spec issue for this: open-telemetry/opentelemetry-specification#530

Other SIGs such as python, ruby, and Java already have implemented such a system.

I don't believe we need to wait for the spec. Even if the spec never merges, we are still technically allowed to use context to stop tracing as it is an SDK concern.

We are currently using a "magic" http header to signal to the http plugin not to trace, but this doesn't work for DNS.

@michaelgoin
Copy link
Contributor

@dyladan Happy to take a stab at this.

@dyladan
Copy link
Member Author

dyladan commented Jun 23, 2020

@michaelgoin great! I assigned you. I was probably going to tackle this by setting the context property in the span processor, but if that doesn't work for you feel free to go your own way

@michaelgoin
Copy link
Contributor

Very sorry for neglecting this for so long. Plan to focus this week and getting something up there.

The one suggested path seems pretty clear around where to check the property and no-op and I'll continue to get more comfortable with how everything is plumbed to make sure that's the right approach.

But I did want to verify what you mean by "setting the context property in the span processor." @dyladan you up for a quick chat either on zoom/whatever or gitter this week? Being new to the project, I just want to make sure I'm really understanding intent.

@dyladan
Copy link
Member Author

dyladan commented Jul 14, 2020

Sure, I'm up for a chat. Go ahead and grab a 30m slot on my calendar https://calendly.com/daniel-dyla/30min

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants